Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(View): add view component style. #1478

Merged
merged 54 commits into from
Jun 4, 2024
Merged

feat(View): add view component style. #1478

merged 54 commits into from
Jun 4, 2024

Conversation

nianxiongdi
Copy link
Collaborator

No description provided.

hiyuki
hiyuki reviewed May 21, 2024
View reviewed changes
packages/webpack-plugin/lib/runtime/components/react/mpx-view.tsx Outdated
}
}

const processTextChildren = (children: React.ReactElement, textStyle:ViewStyle = {}) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥需要这个啊

@nianxiongdi nianxiongdi changed the base branch from feat-react-template-compiler to feat-react-template-compiler-cr May 23, 2024 11:46
hiyuki
hiyuki reviewed Jun 3, 2024
View reviewed changes
packages/webpack-plugin/lib/runtime/components/react/mpx-view.tsx Outdated

function wrapImage(imageStyle) {
const show = useRef(false)
const imageSize = useRef(null)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function useStateRef(initial){
const ref = useRef(initial)
const [_, setState] = useState(initial)
return [ref, (newState)=>{
ref.current = newState
setState(newState)
}]
}

@hiyuki hiyuki merged commit 769ce12 into feat-react-template-compiler Jun 4, 2024
4 checks passed
@hiyuki hiyuki deleted the feat-react-rn-view branch June 4, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiyuki hiyuki hiyuki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nianxiongdi @hiyuki